Skip to content

DevicePathToText and DevicePathFromText Protocol #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 8, 2022

Conversation

supdrewin
Copy link
Contributor

@supdrewin supdrewin commented Apr 3, 2022

@supdrewin
Copy link
Contributor Author

This is the test used by previous PR #398 , but make it panic if the file_path is null (the child loaded from buffer should always panic).

Child:

t11

Parent:

t22

Run:

t33

From the picture we can find the path is successfully converted by the Device Path to Text Protocol.

TODO: This protocol's functions allocated pool which means the callers should free the pool manually.

Copy link
Member

@nicholasbishop nicholasbishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I've left a couple comments inline. Also, it would be good to add some tests for these protocols to uefi-test-runner/src/proto/device_path.rs.

@supdrewin
Copy link
Contributor Author

Thanks for the PR! I've left a couple comments inline. Also, it would be good to add some tests for these protocols to uefi-test-runner/src/proto/device_path.rs.

I add the test for both protocols now.

@nicholasbishop
Copy link
Member

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants