Transform feature "ignore-logger-errors" to additive feature. #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
force-pushed
the
ignore-logger-errors-feature-additive
branch
from
2f0fdad to
469ae72
Compare
nicholasbishop
requested changes
Jul 31, 2022
|
Short notice: I'm currently on vacation and probably won't work on the PRs until the last week of August |
phip1611
force-pushed
the
ignore-logger-errors-feature-additive
branch
from
469ae72 to
dd3d03d
Compare
|
I updated the PR. @nicholasbishop @GabrielMajeri I'm back from vacation btw. Will work on my PRs and help to review other PRs now. |
|
CI failure seems to be unrelated as |
nicholasbishop
approved these changes
Aug 27, 2022
|
Lgtm! See #494 for the CI issue, once that's resolved we can re-run the CI on this and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #456, this PR refactors the
ignore-logger-errorsfeature to the new additivepanic-on-logger-errorsfeature.