Skip to content

is_media_preset -> is_media_present in BlockIOMedia #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

ColinFinck
Copy link
Contributor

This is a breaking typo fix. But as main already contains some breaking changes since 0.16, I feel that it's the right time to fix it.

Copy link
Member

@nicholasbishop nicholasbishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, will run the CI once #494 is resolved

@phip1611
Copy link
Member

phip1611 commented Aug 30, 2022

btw, I just learned recently, that in Rust's definition of semantic versioning for 0.x.y versions, each bump of x should be treated as breaking change.

Apart from that, I think breaking changes in nightly software that has a 0 as major version number are most of the time perfectly fine if the code change itself is sensible. Our users are no beginners anyway, so they should be able to easily cope with that. Our changelog is a good guideline.

@nicholasbishop nicholasbishop merged commit e2cde21 into rust-osdev:main Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants