CStr8 cleanup and enhancements #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
force-pushed
the
cstr8-from-cstr
branch
from
957b31d to
a0f1275
Compare
nicholasbishop
requested changes
Sep 6, 2022
phip1611
force-pushed
the
cstr8-from-cstr
branch
from
a0f1275 to
7f65e6e
Compare
- CStr8 can now be constructed from core::ffi::CStr - CStr8 now also implements EqStrUntilNul
phip1611
force-pushed
the
cstr8-from-cstr
branch
from
7f65e6e to
e20ca0e
Compare
|
rdy for the next review round |
nicholasbishop
approved these changes
Sep 8, 2022
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Rewriting History guide for
help.