Don't explicitly require compiler-builtins(-mem) #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YtvwlD
force-pushed
the
build-std-features
branch
from
0801e36 to
de5923f
Compare
|
Thanks for the PR, looks good to me. We recently discussed how to handle bumping the nightly msrv, and settled on three months for non-critical changes. So we'll plan to merge this around November 8. |
They are implicit on uefi as of rust-lang/compiler-builtins#473. The first nightly version where this is working is 2022-08-08.
nicholasbishop
force-pushed
the
build-std-features
branch
from
de5923f to
2881ec7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are implicit on uefi as of rust-lang/compiler-builtins#473 from June, so we can simplify the examples and the build stuff a bit. This is sort of a follow-up to #298.
Checklist
Rewriting History guide for
help.
I'm not sure whether updating the changelog is necessary as this doesn't really break anything.
Though, this only works with a nightly compiler newer than 2022-08-07, so I guess you might