Allow uefi-services to work when the "logger" feature is disabled in uefi #552
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! We are using these crates in our project (Theseus OS), and we would like to use
uefi
without thelogger
feature.However, I discovered that the
uefi-services
crate forces us to have thelogger
feature enabled inuefi
, as per its manifest.Due to how the
log
crate is implemented, it is impossible to set a logger twice; becauseuefi-services
sets the default one up (and disables it when boot services are exited), we can't set our own logger up.This PR simply adds a
logger
feature touefi-services
, which propagates to the same feature inuefi
. This allows us to use both crates without the built-in logger.