Install UEFI targets via rustup #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasbishop
force-pushed
the
bishop-tier2
branch
from
f2103f7 to
f1dd177
Compare
|
Looks like there are some linker errors in the i686 target, I'll look into that. |
|
very nice |
|
Just a quick note that I'm working on the issues blocking i686 here: rust-lang/rust#104326 |
nicholasbishop
force-pushed
the
bishop-tier2
branch
3 times, most recently
from
f23b7be to
495d6fb
Compare
|
Marking ready for review -- the linker issue with |
phip1611
reviewed
Nov 24, 2022
| @@ -1,3 +1,3 @@ | |||
| [toolchain] | |||
| channel = "nightly" | |||
| components = ["rust-src"] | |||
There was a problem hiding this comment.
this looks so much better now. Very nice :)
phip1611
reviewed
Nov 24, 2022
| // If the target is not installed, use build-std. Keep this | ||
| // around until our minimum-supported nightly version is at | ||
| // least 2022-11-10. | ||
| if !is_target_installed(target.as_triple())? { |
There was a problem hiding this comment.
can you create a follow-up ticket please to remove this eventually?
There was a problem hiding this comment.
I went ahead and made a PR: #585
We can merge that after Feb 22, 2023.
phip1611
approved these changes
Nov 24, 2022
phip1611
force-pushed
the
bishop-tier2
branch
from
495d6fb to
8640cc3
Compare
|
LGTM! |
The UEFI targets are now tier 2, so we don't need to use build-std anymore.
If the target being built is installed via rustup, skip adding the build-std arguments. We still need build-std for our current minimum-supported nightly CI, but for nightly-2022-11-10 and later the UEFI targets are tier 2 and can be installed via rustup.
These targets are now available via rustup as of nightly-2022-11-10.
As of nightly-2022-11-10 the UEFI targets are tier 2 and available via rustup, so build-std isn't needed anymore.
nicholasbishop
force-pushed
the
bishop-tier2
branch
from
8640cc3 to
7b8a188
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of
nightly-2022-11-10the UEFI targets are tier 2 and available via rustup. That means we can switch to building withoutbuild-std.In order to continue testing the older nightly,
cargo xtask buildchecks if the targets are installed and switches back tobuild-stdif not.Fixes #504
Checklist