-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename crate features #561
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
force-pushed
the
feature-rename
branch
from
November 12, 2022 13:28
4f21876
to
98d2c48
Compare
Closed
Closed
phip1611
force-pushed
the
feature-rename
branch
4 times, most recently
from
November 12, 2022 15:27
b0a2ed2
to
257c447
Compare
phip1611
force-pushed
the
feature-rename
branch
3 times, most recently
from
November 12, 2022 15:58
a29afbd
to
fd62a73
Compare
phip1611
force-pushed
the
feature-rename
branch
from
November 14, 2022 08:13
fd62a73
to
806f740
Compare
phip1611
force-pushed
the
feature-rename
branch
from
November 14, 2022 08:13
806f740
to
182499d
Compare
phip1611
force-pushed
the
feature-rename
branch
from
November 18, 2022 07:40
182499d
to
f0202ba
Compare
I updated the PR to match the latest main branch. |
phip1611
force-pushed
the
feature-rename
branch
from
November 18, 2022 07:42
f0202ba
to
b15c60a
Compare
To prevent confusion, this renames the `alloc` crate feature to `global_allocator` and the `exts` feature to `alloc` to match the conventions of the ecosystem.
nicholasbishop
force-pushed
the
feature-rename
branch
from
November 19, 2022 16:49
b15c60a
to
bb5fcc3
Compare
nicholasbishop
approved these changes
Nov 19, 2022
Cool, I'm glad this could be merged. Now, I do not expect much more PRs that will result in big merge conflicts in the next weeks/months. I'm going to rebase my existing other PRs soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the ideas of #560 .
Checklist