xtask: Enable strict provenance checks in Miri #666
Conversation
xtask/src/cargo.rs
Outdated
| // around until our minimum-supported nightly version is at | ||
| // least 2022-11-10. | ||
| if !is_target_installed(target.as_triple())? { | ||
| cmd.args(["-Zbuild-std=core,alloc"]); |
There was a problem hiding this comment.
We just merged #585 .. so this can be omitted, I guess?
There was a problem hiding this comment.
Oops! Not quite sure how that code snuck back in here, fixed.
|
Wonderful, nice catch! strict pointer provenance and its analysis is still under development to my knowledge. So we probably can expect that working code might fail in future nightly versions because of additional checks, right? |
nicholasbishop
force-pushed
the
bishop-strict-prov
branch
from
433b04f to
55c81ae
Compare
Yep, I think that's correct. Probably also generally true for any Miri thing actually, I don't think there are any stability guarantees on what it checks right now, but pointer provenance is maybe more likely to give the occasional nightly failure. |
nicholasbishop
force-pushed
the
bishop-strict-prov
branch
from
55c81ae to
79c4ef7
Compare
phip1611
force-pushed
the
bishop-strict-prov
branch
from
79c4ef7 to
d8e469c
Compare
I noticed while testing #662 that Miri is printing some useful warnings about pointer/integer casts. Enabling the
-Zmiri-strict-provenanceflag turns these warnings into errors so that they'll fail CI, otherwise it's easy to miss them.Checklist