Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: implement remove_dir_all #799

Merged
merged 4 commits into from
May 12, 2023
Merged

Conversation

phip1611
Copy link
Contributor

With this PR, the fs module is feature-complete and ready to be shipped.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@phip1611 phip1611 requested a review from nicholasbishop May 11, 2023 09:28
@phip1611 phip1611 force-pushed the fs-delete-dir-all branch 3 times, most recently from 4a20782 to d461086 Compare May 11, 2023 09:41
Copy link
Member

@nicholasbishop nicholasbishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit about commented code, otherwise lgtm

uefi/src/fs/file_system/fs.rs Outdated Show resolved Hide resolved
@phip1611 phip1611 force-pushed the fs-delete-dir-all branch from d461086 to e117773 Compare May 11, 2023 21:06
@phip1611 phip1611 force-pushed the fs-delete-dir-all branch from e117773 to bc8d8db Compare May 12, 2023 05:59
@phip1611 phip1611 merged commit dd94198 into rust-osdev:main May 12, 2023
@phip1611 phip1611 deleted the fs-delete-dir-all branch May 12, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants