-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cargo doc
is broken when default-featues = false
#307
Comments
|
npmccallum
added a commit
to npmccallum/x86_64
that referenced
this issue
Sep 16, 2021
Fixes: rust-osdev#307 Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
Thanks for reporting! I agree that this is unfortunate and should be fixed as soon as possible. I'm not sure if #308 is a good solution to this (see my comment there), but I'm currently working on a different solution. |
phil-opp
added a commit
that referenced
this issue
Sep 17, 2021
The segment types themselves do not require the `instructions` feature, so it makes sense to move them to the top-level `registers` module. The `instructions::segmentation` module still re-exports all the types, so this change should not break any code. Fixes #307
I opened a PR in #309. |
phil-opp
added a commit
that referenced
this issue
Sep 17, 2021
The segment types themselves do not require the `instructions` feature, so it makes sense to move them to the top-level `registers` module. The `instructions::segmentation` module still re-exports all the types, so this change should not break any code. Fixes #307
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is particularly nasty because it also breaks
cargo doc
on all downstream uses of this crate withdefault-features = false
.The text was updated successfully, but these errors were encountered: