optimize Step impl for VirtAddr
#462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This eliminates the call to unwrap which the compiler can't easily optimize out.
This eliminates a panic branch.
The last two commits introduced some shortcuts that are less obviously correct. Using unsafe is inherently risky, so we better be sure that the code is correct. The proof harnesses added in this patch can be used to proof that our implementation is correct for all inputs.
phil-opp
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes the
Stepmethods forVirtAddr.Some of these optimizations were already present in the PR that introduced the
Stepimplementation but were removed over safety concerns. To address these concerns, this PR also adds some kani proof harnesses to prove the correctness of the implementations. The proof harnesses are run in CI.