Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor clarification DescriptorTablePointer::limit comment #503

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

mrjbom
Copy link
Contributor

@mrjbom mrjbom commented Oct 19, 2024

limit in gdtr contain size - 1

@mrjbom mrjbom changed the title Minor clarification Minor clarification DescriptorTablePointer::limit comment Oct 19, 2024
Copy link
Member

@Freax13 Freax13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Freax13 Freax13 enabled auto-merge October 20, 2024 11:38
@Freax13 Freax13 disabled auto-merge October 21, 2024 17:42
@Freax13
Copy link
Member

Freax13 commented Oct 21, 2024

The CI failures are unrelated to this PR. I created a fix in #507. I'll restart auto-merge once #507 (or an alternative) is merged. I apologize for the delays.

@Freax13
Copy link
Member

Freax13 commented Nov 16, 2024

#507 was merged. I rebased this PR onto master to fix CI.

@Freax13 Freax13 enabled auto-merge November 16, 2024 12:06
@Freax13 Freax13 merged commit e016a4c into rust-osdev:master Nov 16, 2024
12 of 13 checks passed
@mrjbom mrjbom deleted the mrjbom-gdt-patch-1 branch November 18, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants