Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make input context could clone device value from output ctx #173

Closed
wants to merge 5 commits into from

Conversation

dbydd
Copy link
Contributor

@dbydd dbydd commented Aug 26, 2024

  • make input context could clone device context from output context, just for convenience

@@ -77,6 +77,12 @@ impl<const N: usize> Input<N> {
device: Device::new(),
}
}

/// copy output ctx to input
/// refer linux code
Copy link
Member

@toku-sa-n toku-sa-n Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, and sorry for the delay.
Could you tell me the exact location for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's located at here
btw, here is how I use it in my project
and one more thing: i added some more utilitity functions after first pr,just for convenient

@dbydd
Copy link
Contributor Author

dbydd commented Aug 28, 2024

it seems like "pointer_structural_match" clippy check option had beed moved to hard error in current version, so fixed it by just delete it

@toku-sa-n
Copy link
Member

Thank you for the explanation. I'm sorry, but I'm slightly against adding these methods because I want this crate to be simple; data structures should have field modifiers, not a composition of them. For your disable_endpoint, isn't it possible to call bit modifiers and value setters for the slot context?

Meanwhile, I appreciate the clippy-related fix. Could you create another PR for the fix? I'll merge it immediately then.

@dbydd dbydd closed this Aug 31, 2024
@dbydd
Copy link
Contributor Author

dbydd commented Aug 31, 2024

okay, pr submitted.
but i want keep this fork in my project(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants