-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis #112
Travis #112
Conversation
Hi, I'll review this tomorrow morning! |
@Wojtek242 windows builds should work fine (at least they did 3 years ago) if you merge/incorporate #83 and #88. Winpcap has not been maintained for almost a decade, even wireshark ships npcap now, I recommend linking against npcap. We have solved more bugs in this crate, I recommend that you take a look :) If you switch to github actions, you might have a better time with your CI setup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
For #113 windows CI, I'm going to use GitHub Actions because it's faster and easier than appveyor. When I make a PR for Windows CI, I might merge travis jobs into GitHub Actions. But for now fixing existing Travis job is the priority. Please go ahead.
Nice suggestion! |
Thanks for suggestions. I'll look into PRs before implementing #113. |
Fix and update Travis build:
streamlisten
example.cargo
command, not a feature.The PR also slightly reformats a few things to make it easier to add Windows builds.
@sekineh I will leave the windows build setup to you, but this is what I set up on my branch: https://github.com/Wojtek242/pcap/blob/master/.travis.yml but I'm not a windows dev so there might be better ways of getting it done. I had quite the headache getting winpcap installed (chocolate install wasn't working for whatever reason).
This PR will be followed by a few more from my branch. Having builds working would make that easier.