Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis #112

Merged
merged 3 commits into from
Aug 25, 2020
Merged

Travis #112

merged 3 commits into from
Aug 25, 2020

Conversation

Wojtek242
Copy link
Collaborator

Fix and update Travis build:

  1. Fix causes of failure: homebrew and required feature for streamlisten example.
  2. Fix how clippy is run. Current advice is to run as cargo command, not a feature.
  3. Remove nightly builds as they are unnecessary and time will be better spent adding windows builds.

The PR also slightly reformats a few things to make it easier to add Windows builds.

@sekineh I will leave the windows build setup to you, but this is what I set up on my branch: https://github.com/Wojtek242/pcap/blob/master/.travis.yml but I'm not a windows dev so there might be better ways of getting it done. I had quite the headache getting winpcap installed (chocolate install wasn't working for whatever reason).

This PR will be followed by a few more from my branch. Having builds working would make that easier.

@Wojtek242 Wojtek242 added the bug label Aug 23, 2020
@Wojtek242 Wojtek242 requested a review from sekineh August 23, 2020 16:16
@sekineh
Copy link
Collaborator

sekineh commented Aug 24, 2020

Hi, I'll review this tomorrow morning!

@Trolldemorted
Copy link
Contributor

I guess this includes #86 and #89. Should I close them?

@Trolldemorted
Copy link
Contributor

@Wojtek242 windows builds should work fine (at least they did 3 years ago) if you merge/incorporate #83 and #88. Winpcap has not been maintained for almost a decade, even wireshark ships npcap now, I recommend linking against npcap.

We have solved more bugs in this crate, I recommend that you take a look :)

If you switch to github actions, you might have a better time with your CI setup.

Copy link
Collaborator

@sekineh sekineh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

For #113 windows CI, I'm going to use GitHub Actions because it's faster and easier than appveyor. When I make a PR for Windows CI, I might merge travis jobs into GitHub Actions. But for now fixing existing Travis job is the priority. Please go ahead.

@sekineh
Copy link
Collaborator

sekineh commented Aug 25, 2020

I guess this includes #86 and #89. Should I close them?

Nice suggestion!
@Wojtek242 , please add description "Closes #86, #89" or close it manually after PR merge.

@sekineh
Copy link
Collaborator

sekineh commented Aug 25, 2020

@Wojtek242 windows builds should work fine (at least they did 3 years ago) if you merge/incorporate #83 and #88. Winpcap has not been maintained for almost a decade, even wireshark ships npcap now, I recommend linking against npcap.

We have solved more bugs in this crate, I recommend that you take a look :)

If you switch to github actions, you might have a better time with your CI setup.

Thanks for suggestions. I'll look into PRs before implementing #113.
I'm still using WinPcap but consider npcap as primary target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants