Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve github actions #121

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Conversation

Trolldemorted
Copy link
Contributor

Some tweaks to your github actions:

  • all operating systems and configurations in one matrix:
      matrix:
        os: [windows-latest, ubuntu-latest, macos-latest]
        profile: ['', --release]
        toolchain: [stable]
        features: ['']

I have deliberately not added the nightly toolchain and the features, because the build would fail due to the aforementioned bugs, but turning them on is just 1 loc change.

@sekineh sekineh self-assigned this Aug 28, 2020
Copy link
Collaborator

@sekineh sekineh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks like a very good infra!

Feature testing is crucial part of CI, please consider re-enable it again very soon.

os: [windows-latest, ubuntu-latest, macos-latest]
profile: ['', --release]
toolchain: [stable]
features: ['']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You disabled features testing (tokio, full).
If you enable tokio will CI fail? (Previously succeeded)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes --features tokio fails. #120

@sekineh sekineh merged commit 04efe4c into rust-pcap:master Aug 28, 2020
@Wojtek242 Wojtek242 mentioned this pull request Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants