Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Npcap CI #273

Merged
merged 7 commits into from
Aug 29, 2022
Merged

Npcap CI #273

merged 7 commits into from
Aug 29, 2022

Conversation

Wojtek242
Copy link
Collaborator

@Wojtek242 Wojtek242 commented Aug 29, 2022

Closes #196 #134

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@Wojtek242 Wojtek242 changed the title First attempt at npcap oem in ci Npcap CI Aug 29, 2022
@Wojtek242 Wojtek242 merged commit 348aa8b into main Aug 29, 2022
This was referenced Aug 29, 2022
@Wojtek242
Copy link
Collaborator Author

Wojtek242 commented Aug 29, 2022

Disclaimer:

Secrets are not passed to workflows that are triggered by a pull request from a fork.

and since we need secrets to silently install npcap with the oem version we cannot run tests using npcap in pull requests from public forkrs. Therefore, windows test builds are now restricted to after PRs have been accepted. Since we still build the windows binaries and Linux and MAC OS X still run the tests that's acceptable for a bindings library.

@Wojtek242 Wojtek242 deleted the windows-npcap-ci branch October 1, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paths for Upgrading Winpcap to Npcap for Microsoft Windows
1 participant