Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Windows XP support #177

Merged
merged 3 commits into from
Jan 3, 2021
Merged

Remove Windows XP support #177

merged 3 commits into from
Jan 3, 2021

Conversation

newpavlov
Copy link
Member

Closes #65.

@josephlr
Copy link
Member

josephlr commented Jan 2, 2021

I'm totally down with removing XP support, but I'm not sure about switching over the implementation for Windows 7,8,10

Initially, I thought it would be fine, but the fact that Go and BoringSSL didnt switch means this probably should have a second look. I'll review the logic in those threads and try to see if I can find any (external or internal) reasoning for not switching.

I suspect that it doesn't matter, in which case we should switch implementations, but I want to be sure.

@newpavlov newpavlov mentioned this pull request Jan 2, 2021
@josephlr
Copy link
Member

josephlr commented Jan 3, 2021

@newpavlov I kept the content of this PR the same, but redid the commit ordering. That way, when this PR is merged, windows.rs will keep the windows_uwp.rs git blame (instead having this PR appear like a change to windows.rs).

Copy link
Member

@josephlr josephlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, see my comment in the bug for why I think switching is fine.

Signed-off-by: Joe Richey <joerichey@google.com>
@josephlr josephlr merged commit a37be0d into master Jan 3, 2021
@josephlr josephlr deleted the winxp branch January 3, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows: RtlGenRandom vs BCryptGenRandom
2 participants