-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tvOS and watchOS support, identical to iOS support #317
Conversation
Given that these targets are not super well supported currently, it's fine that we don't run the tests in CI. However, we should do something similar to our build and link tests for Apple Arm64. You should just be able to add the targets to the tests.yml |
Hm, For tvos it's not currently supported in libstd, so the best we could do is |
Does this issue occur of the other watchOS targets (i.e. If you can get one of them working, add it here.
Makes sense. If linking doesn't work, just add a comment and put the watchOS target with the tvOS target for now.
This makes sense, can you add |
Good call, the simulator targets work, which actually helps point out what this issue probably is. Thanks. Some notes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than some nits for the CI, this looks reasonable.
Bumping the libc
version is fine. For reference rust-lang/libc@bf618c9 is the commit we need.
Thanks, is this more what you meant? |
Ah, -Zbuild-std requires nightly, do you want me to move it to another job, or would you rather make that one use nightly? |
Having that one use nightly is fine, ideally it would be in its own job, but macOS runners are slow and constrained on Github Actions, so reducing the jobs generally makes things better. |
I've updated that job to nightly. |
This adds tvOS and watchOS support. Support in the Rust stdlib in watchOS is recent, and tvOS is in progress.
These OSes all can use the same interface from Security.framework. Ideally they'd use
getrandom
, but sadly they currently cannot. I've renamedios.rs
toapple-other.rs
as a result of this, but there are no other changes.