Skip to content

Conversation

josephlr
Copy link
Member

Depends on #471

Now when running cargo test we see the additional rdrand tests:

running 11 tests
test error::tests::test_size ... ok
test rdrand::tests::fill_large ... ok
test rdrand::tests::fill_zero ... ok
test tests::fill_large ... ok
test tests::fill_zero ... ok
test rdrand::tests::multithreading ... ok
test tests::multithreading ... ok
test rdrand::tests::fill_small ... ok
test tests::fill_small ... ok
test tests::fill_huge ... ok
test rdrand::tests::fill_huge ... ok

I think the main question here is if we should unconditionally run these tests like we did before, or if we should only run them if the "rdrand" feature is set.

@josephlr josephlr mentioned this pull request Jun 12, 2024
@newpavlov
Copy link
Member

As I wrote here, this probably can be done a bit better.

@josephlr josephlr mentioned this pull request Jun 19, 2024
@josephlr josephlr force-pushed the test_rdrand branch 3 times, most recently from 6238ad6 to fb5d54c Compare June 19, 2024 07:45
josephlr added 2 commits June 19, 2024 03:25
Signed-off-by: Joe Richey <joerichey@google.com>
Signed-off-by: Joe Richey <joerichey@google.com>
@josephlr
Copy link
Member Author

Closing to keep conversation in #471

@josephlr josephlr closed this Jun 20, 2024
@newpavlov newpavlov deleted the test_rdrand branch June 20, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants