Clarify documentation of choose_weighted(_mut) mentioning accurate behavior with floats
#1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…htedIndex` as discussed in rust-random#1243. Additionally fix some minor issues.
…hey are handled correctly for the zero case.
dhardy
approved these changes
Oct 10, 2022
|
No worries, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes as discussed in this comment in #1243
perhaps right before the example using weights of zero in the WeightedIndex docs.I added the mention of zero weight in the first paragraph of the documentation.
Additionally
WeightedIndexandFeel free to request changes, this is my first contribution to this repository, so I don't really see the big picture.
Closes #1243