-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use OsRng
for thread_rng
.
#133
Conversation
I think we need to examine this for performance impact. |
8c35e6c
to
c9f8b2b
Compare
Yes unfortunately when we've done this in the past the performance has been unacceptably slow afterwards, unfortunately. @tomprince did you find evidence to the contrary, however? |
@alexcrichton what precisely has unacceptable performance? This change has been argued for quite a bit in the crate evaluation thread. If we're talking about specific applications, we may still want to use |
@dhardy historically the Now that's mainly something to deal with the standard library, and it's probably the case no matter what that we'll never switch |
Can we not do that? No matter the origins, this will lead to catastrophic performance in some programs as people use thread_rng liberally as an |
I'd propose this approach : Abstract Replace Add an I think this provides a |
@burdges given that the current |
Closing (see reason in #78). |
Fixes #78.