gen_ratio -> random_probability, gen_bool -> random_probability_f64 #1527
+39
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oconnor663
force-pushed
the
probability
branch
from
f0e4bf3
to
c1de15d
Compare
oconnor663
force-pushed
the
probability
branch
from
c1de15d
to
cd3354b
Compare
|
I don't much like this — too long, @newpavlov's suggestion to use some trait like |
|
Yeah that's fair. There's some precedent in the standard library, but maybe it doesn't feel great there either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure I actually love these names, but I wanted to continue the discussion that @dhardy and @newpavlov were having in #1488. What do you guys think of this option?