-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ChaChaRng and Hc128Rng to their own crates #607
Conversation
This fixes #431 (only what is said in the title, not the whole list in the issue). |
I'll have a look, but presumably not before next week, when I'm back from
vacation.
…On Thu, Sep 20, 2018, 10:30 Diggory Hardy ***@***.***> wrote:
Okay @vks <https://github.com/vks> could you please update in line with
#611 <#611>? In particular, the
authors line (ChaCha should list both; Hc128 can just list the Rand
project devs). Also, the LICENSE-MIT files.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#607 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AACCtAdm0fJfTtXcfUl-ahDj4-qD-ah8ks5uc1IMgaJpZM4WpPPO>
.
|
@dhardy I think I addressed all your concerns. I'll squash after review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vks, mostly looks good.
I see you updated script.sh
but this is only for the Trust cross tests. You should update .travis.yml and appveyor.yml too.
I don't know what is going on with those MIPS and ARMv7 failures. The rest should be fine now. |
Me neither. On both runners the ChaCha crate passes but the HC128 one fails. There's very little difference between the Cargo.toml or lib files; the only significant thing I see is a build script for ChaCha. You can just comment out the hc128 cross-tests and merge if you like; everything else looks good. |
They fail to link for unknown reasons. Also see rust-random#607.
This leaves
rand::prng
as a module only containing deprecated code. In principle it could be removed/hidden, but we still want to have the PRNG comparison somewhere.