Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ChaChaRng and Hc128Rng to their own crates #607

Merged
merged 6 commits into from
Sep 27, 2018

Conversation

vks
Copy link
Collaborator

@vks vks commented Sep 14, 2018

This leaves rand::prng as a module only containing deprecated code. In principle it could be removed/hidden, but we still want to have the PRNG comparison somewhere.

@vks
Copy link
Collaborator Author

vks commented Sep 14, 2018

This fixes #431 (only what is said in the title, not the whole list in the issue).

@dhardy
Copy link
Member

dhardy commented Sep 17, 2018

Thanks @vks.

The CI seems to be complaining about broken links in the documentation.

Could you rebase after #611 please with the relevant changes?

@dhardy
Copy link
Member

dhardy commented Sep 20, 2018

Okay @vks could you please update in line with #611? In particular, the authors line (ChaCha should list both; Hc128 can just list the Rand project devs). Also, the LICENSE-MIT files.

@vks
Copy link
Collaborator Author

vks commented Sep 20, 2018 via email

@vks
Copy link
Collaborator Author

vks commented Sep 25, 2018

@dhardy I think I addressed all your concerns. I'll squash after review.

Copy link
Member

@dhardy dhardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vks, mostly looks good.

I see you updated script.sh but this is only for the Trust cross tests. You should update .travis.yml and appveyor.yml too.

rand_chacha/CHANGELOG.md Outdated Show resolved Hide resolved
rand_chacha/Cargo.toml Outdated Show resolved Hide resolved
rand_chacha/Cargo.toml Show resolved Hide resolved
rand_chacha/README.md Outdated Show resolved Hide resolved
rand_chacha/build.rs Show resolved Hide resolved
rand_hc128/CHANGELOG.md Outdated Show resolved Hide resolved
rand_hc128/Cargo.toml Outdated Show resolved Hide resolved
rand_hc128/README.md Outdated Show resolved Hide resolved
rand_hc128/README.md Outdated Show resolved Hide resolved
rand_chacha/README.md Outdated Show resolved Hide resolved
@vks
Copy link
Collaborator Author

vks commented Sep 25, 2018

I don't know what is going on with those MIPS and ARMv7 failures. The rest should be fine now.

@dhardy
Copy link
Member

dhardy commented Sep 25, 2018

Me neither. On both runners the ChaCha crate passes but the HC128 one fails. There's very little difference between the Cargo.toml or lib files; the only significant thing I see is a build script for ChaCha.

You can just comment out the hc128 cross-tests and merge if you like; everything else looks good.

They fail to link for unknown reasons. Also see rust-random#607.
@vks vks merged commit 7aec8e2 into rust-random:master Sep 27, 2018
@vks vks deleted the extract-csprng branch September 27, 2018 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants