Move rustc_version dep to autocfg
#664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhardy
approved these changes
Dec 12, 2018
Member
dhardy
left a comment
dhardy
left a comment
There was a problem hiding this comment.
Shame the syntax is so much more clunky, but looks adequate.
vks
reviewed
Dec 12, 2018
Contributor
Author
|
I've proposed a slightly tweaked API which in theory could make this much more ergonomic, and it's fine to wait for the resolution of that! |
The `rustc_version` dependency is weighty and suffers from djc/rustc-version-rs#11 which makes it more difficult to change rustc over time.
alexcrichton
force-pushed
the
version-check
branch
from
d084a89 to
e59539b
Compare
alexcrichton
changed the title
rustc_version dep to version_checkrustc_version dep to autocfg
Contributor
Author
|
Ah I also discovered |
vks
approved these changes
Dec 14, 2018
Member
|
Agreed! Thanks all. |
Contributor
|
autocfg seems to hinders cross-compilation and workflows involving |
Collaborator
|
|
Contributor
|
Oh yeah, forgot we are still on rand 0.6, sorry for the noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rustc_versiondependency is weighty and suffers fromdjc/rustc-version-rs#11 which makes it more difficult to change
rustc over time.