Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement initial num-traits #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

boomshroom
Copy link

This implements the first 6 traits from num-traits when the num feature is enabled.

Aside from the conversion traits and Zero, these all correspond to methods already implemented.

@kjetilkjeka
Copy link
Collaborator

Thanks @boomshroom !

As explained in #19 these traits should require some nightly only unstable feature as well, the short explanation why is that num_traits are not considered stable enough to have a public dependency on at this point.

A test (travis job) that verify these unstables features cannot be included on stable would be great as well.

@dzmitry-lahoda
Copy link

currently these are stable

@bbaldino
Copy link
Collaborator

I've got an updated take on some of these here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants