-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual update dependencies in rust-vmm crates - and provide releases #136
Comments
I went through all of the rust-vmm crates and created the following table that keeps track of all their dependencies and whether they currently rely on (a) non-caret requirements and (b) outdated versions
|
Going through the dependency graph, updates need to be done in the following order (all crates on the same level can be updated in parallel):
|
Based on @roypat's analysis, we need to go through 3 stages (corresponding to the number list above). Stage 1vm-superio - DONEChanges Needed:
Blocks: vm-superio-ser event-manager - DONEChanges Needed:
Blocks: N/A vm-memory - DONEChanges Needed:
Blocks:
kvm-bindings - DONEChanges Needed:
|
See rust-vmm/community#136 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
See rust-vmm/community#136 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
See rust-vmm/community#136 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
See rust-vmm/community#136 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
At this point, all stage 1 crates have PRs open fixing this issues. Next step is their crates.io release, so we can start working on the Step 2 crates. |
kvm-bindings v0.7.0 is released ✅ |
See rust-vmm/community#136 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
See rust-vmm/community#136 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Is that v0.6.0 or a newer version of kvm-bindings is planned to release? |
It is 0.6.0. |
See rust-vmm/community#136 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
See rust-vmm/community#136 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
See rust-vmm/community#136 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
See rust-vmm/community#136 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
See rust-vmm/community#136 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
See rust-vmm/community#136 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
vmm-sys-util 0.10.0 -> 0.11.0 kvm-bindings 0.5.0 -> 0.6.0 See rust-vmm/community#136 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
See rust-vmm/community#136 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
See rust-vmm/community#136 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
See rust-vmm/community#136 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
See rust-vmm/community#136 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
vmm-sys-util 0.10.0 -> 0.11.0 kvm-bindings 0.5.0 -> 0.6.0 See rust-vmm/community#136 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
See rust-vmm/community#136 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Stage 2vm-superio-ser - DONEkvm-ioctls - DONE
virtio-queue - DONE
linux-loader - DONE |
See rust-vmm/community#136 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
See rust-vmm/community#136 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
See rust-vmm/community#136 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
See rust-vmm/community#136 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
See rust-vmm/community#136 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
See rust-vmm/community#136 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
See rust-vmm/community#136 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
See rust-vmm/community#136 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
vmm-sys-util 0.9.0 -> 0.11.0 See rust-vmm/community#136 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Update dependencies to use recommended versions and version syntax. See: rust-vmm/community#136 Signed-off-by: Rob Bradford <robert.bradford@intel.com>
Update dependencies to use recommended versions and version syntax. See: rust-vmm/community#136 Signed-off-by: Rob Bradford <robert.bradford@intel.com>
Update dependencies to use recommended versions and version syntax. See: rust-vmm/community#136 Signed-off-by: Rob Bradford <robert.bradford@intel.com>
vmm-sys-util 0.9.0 -> 0.11.0 See rust-vmm/community#136 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
I know that a release is missing for (at least) vhost-user-backend. |
This is all done now. Thanks to @stefano-garzarella. |
@jiangliu @liuw @sameo @sboeuf can one of you take care of the two crates as well? What is important is properly setting the crate requirements to caret (if they have any that are not properly specified), and provide a release. |
And also bump the crate versions as well as the dependency versions. See: rust-vmm/community#136 Signed-off-by: Rob Bradford <robert.bradford@intel.com>
And also bump the crate versions as well as the dependency versions. See: rust-vmm/community#136 Signed-off-by: Rob Bradford <robert.bradford@intel.com>
And also bump the crate versions as well as the dependency versions. See: rust-vmm/community#136 Signed-off-by: Rob Bradford <robert.bradford@intel.com>
And also bump the crate versions as well as the dependency versions. See: rust-vmm/community#136 Signed-off-by: Rob Bradford <robert.bradford@intel.com>
This update is needed because otherwise there will be crates using vmm-sys-util 0.10.0 and others using 0.11.0. The reason behind this is the (wrong) way in which we specify dependencies in a few of the rust-vmm crates. Specifically, some crates will just pick up the latest available version of a crate even if it introduces breaking changes (i.e. picking up 0.11.0 because the dep is specified as
>= 0.9.0
). We're progressively fixing this by always having dependencies specified with caret, but this work was not yet completed for a few crates. As such, we need to:The order in which we provide releases matters because of the dependency between crates.
For example, we first need to update kvm-bindings, publish it, and then update kvm-ioctls by specifying a new version for both vmm-sys-util and kvm-bindings.
This issue is tracking this one time effort. We're not tracking here a saner way to do the updates, as this is going to happen afterwards. Tracking issues: #135 & TBD (for releases).
The text was updated successfully, but these errors were encountered: