Enable KVM_SET/GET_VCPU_EVENTS ioctls for Aarch64. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael2012z
requested review from
acatangiu,
alxiord,
andreeaflorescu and
sameo
as code owners
acatangiu
reviewed
Dec 2, 2019
There was a problem hiding this comment.
Code changes look good.
Please rework your commit message to follow the Git 50/72 rule.
Also you have some typos in the commit message s/KVM_GET_VCGP_EVENTS/KVM_GET_VCPU_EVENTS and s/KVM_SET_VCGP_EVENTS/KVM_SET_VCGP_EVENTS
KVM_GET_VCPU_EVENTS and KVM_SET_VCPU_EVENTS ioctls have been supported on Aarch64 from a recent kernel version. This patch enables them on Aarch64 and checked cap KVM_CAP_VCPU_EVENTS before calling them in test code to avoid error in old kernel. Change-Id: I9526b48948cf0cd5d63444a82b8b09970311a3bb Signed-off-by: Michael Zhao <michael.zhao@arm.com>
michael2012z
force-pushed
the
aarch64_vcpu_events
branch
from
f828d77
to
1908f99
Compare
|
@acatangiu Thank you. Updated. |
acatangiu
approved these changes
Dec 3, 2019
jiangliu
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable KVM_SET/GET_VCPU_EVENTS ioctls for Aarch64.
KVM_GET_VCPU_EVENTS and KVM_SET_VCPU_EVENTS ioctls have been supported
on Aarch64 from a recent kernel version.
This patch enables them on Aarch64 and checked cap KVM_CAP_VCPU_EVENTS
before calling them in test code to avoid error in old kernel.
Signed-off-by: Michael Zhao michael.zhao@arm.com