Add support for StandardRegisters on ARM64 #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinankjain
requested review from
russell-islam,
liuw and
NunoDasNeves
as code owners
jinankjain
force-pushed
the
staging
branch
2 times, most recently
from
572e392 to
c1c7582
Compare
jinankjain
force-pushed
the
staging
branch
3 times, most recently
from
90b6c06 to
13b43db
Compare
jinankjain
force-pushed
the
staging
branch
2 times, most recently
from
996658a to
7fbeca1
Compare
It's been quite sometime that we synced register names and currently missing ARM64 register names. Signed-off-by: Jinank Jain <jinankjain@microsoft.com>
russell-islam
approved these changes
Jan 29, 2025
|
LGTM |
Along with it also add an interface to get/set StandardRegisters. Signed-off-by: Jinank Jain <jinankjain@microsoft.com>
Signed-off-by: Jinank Jain <jinankjain@microsoft.com>
After this all the test compiles and runs on ARM64. Signed-off-by: Jinank Jain <jinankjain@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
With this change, we implement support for basic StandardRegisters interface for ARM64. Along with it also add a unit test to test get/set reg interface on ARM64.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.