vsock: always epoll_register with cloned stream fd #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikicha
requested review from
mathieupoirier,
stsquad,
vireshk and
stefano-garzarella
as code owners
VsockConnection::stream which is cloned is always used for epoll_register, except add_new_guest_conn. Only in add_new_guest_conn, the original stream is used. Because a stream's raw fd is used for the key of listener_map, it cannot find proper listener after the first packet. Signed-off-by: Jeongik Cha <jeongik@google.com>
stefano-garzarella
approved these changes
Jul 27, 2023
epilys
approved these changes
Jul 27, 2023
vireshk
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VsockConnection::stream which is cloned is always used for
epoll_register, except add_new_guest_conn. Only in add_new_guest_conn,
the original stream is used.
Because a stream's raw fd is used for the key of listener_map, it cannot
find proper listener after the first packet.
Fixes #407