vsock: Don't allow duplicate CIDs #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techiepriyansh
requested review from
mathieupoirier,
stsquad,
vireshk and
stefano-garzarella
as code owners
techiepriyansh
force-pushed
the
fix-conflicting-cids
branch
from
9f9a7a7 to
39423e3
Compare
techiepriyansh
changed the title
stefano-garzarella
approved these changes
Sep 13, 2023
stefano-garzarella
force-pushed
the
fix-conflicting-cids
branch
from
39423e3 to
36804cf
Compare
Currently, while updating the `cid_map`, it is not checked if the map already contained a key with the same CID before. So, fail to create the vsock thread if the CID is already in use. Signed-off-by: Priyansh Rathi <techiepriyansh@gmail.com>
stefano-garzarella
force-pushed
the
fix-conflicting-cids
branch
from
36804cf to
b460fc7
Compare
|
@stsquad @mathieupoirier can you take a look? It's a simple bug fix we introduce when starting to support sibling VMs. |
vireshk
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, while updating the
cid_map, it is not checked if the map already contained a key with the same CID before. So, fail to create the vsock thread if the CID is already in use.Fixes #432.