scmi: revert to previous --help-devices behavior #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit b37e7e5 changed how the --help-deices text output was used inadvertently by including it by default in the help output. Restore the --help-devices argument and make it exclusive: you cannot combine it with other arguments. This way, socket_path does not have to be an Option<PathBuf>. Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
epilys
requested review from
stsquad,
vireshk and
stefano-garzarella
as code owners
Ablu
approved these changes
Dec 6, 2023
stefano-garzarella
approved these changes
Dec 6, 2023
vireshk
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit b37e7e5 changed how the --help-devices text output was used inadvertently by including it by default in the help output. Restore the --help-devices argument and make it exclusive: you cannot combine it with other arguments. This way, socket_path does not have to be an Option.
Cc @mz-pdm
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.