sound/pipewire: destroy multiple pipewire streams that are not destroyed #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorindabassey
requested review from
stsquad,
vireshk,
stefano-garzarella and
epilys
as code owners
epilys
reviewed
Apr 2, 2024
|
LGTM. I also wonder if panicking is the correct behavior when it is not possible to disconnect. |
dorindabassey
force-pushed
the
fixstream
branch
2 times, most recently
from
ee9ddde to
1809dae
Compare
epilys
requested changes
Apr 3, 2024
dorindabassey
force-pushed
the
fixstream
branch
2 times, most recently
from
a760bfd to
f049401
Compare
epilys
previously approved these changes
Apr 5, 2024
epilys
reviewed
Apr 5, 2024
The PCM command transition prepare->prepare or set_param->prepare is allowed by the specification. Pipewire, however, creates multiple streams which are not destroyed when this type of transition happens. By using this PR, we can ensure that when the prepare function in the pipewire backend is called multiple times without the release function, only one pipewire stream is created. Signed-off-by: Dorinda Bassey <dbassey@redhat.com>
epilys
approved these changes
Apr 8, 2024
stefano-garzarella
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
The PCM command transition prepare->prepare or set_param->prepare is allowed by the specification. however this type of transition in pipewire lead to multiple creation of pipewire streams that are not destroyed. This PR ensures that in a case like this, when the prepare fn() in the pipewire backend is called multiple times without the release fn(), there should be only one pipewire stream.
Close #490
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.