Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsock/README: simplify the examples using memfd #672

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

stefano-garzarella
Copy link
Member

Summary of the PR

In the examples we used hugepages, which could be useful in special cases where the performance matters, but this requires specific configuration and permissions to allocate them.

Let's simplify the examples by using memfd, removing --mem-prealloc, and the superfluous -m 512M.

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

  • All commits in this PR have Signed-Off-By trailers (with
    git commit -s), and the commit message has max 60 characters for the
    summary and max 75 characters for each description line.
  • All added/changed functionality has a corresponding unit/integration
    test.
  • All added/changed public-facing functionality has entries in the "Upcoming
    Release" section of CHANGELOG.md (if no such section exists, please create one).
  • Any newly added unsafe code is properly documented.

In the examples we used hugepages, which could be useful in
special cases where the performance matters, but this requires
specific configuration and permissions to allocate them.

Let's simplify the examples by using memfd, removing
`--mem-prealloc`, and the superfluous `-m 512M`.

Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
@epilys epilys enabled auto-merge (rebase) June 11, 2024 07:53
@epilys epilys merged commit 4c45d03 into rust-vmm:main Jun 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants