vhost_user: handle recv_with_fds being unsafe #69
Conversation
|
Hi alyssais, could you please help to fix the CI failures? |
|
@jiangliu the CI failures are just coming from the Should I change Cargo.toml to have it use the latest vmm-sys-util from git, or would you like to do a vmm-sys-util release including the latest changes that we could update to? |
Hi @alyssais , we have just published vmm-sys-util v0.9.0, could you please give another try? |
alyssais
force-pushed
the
unsafe_iovec
branch
from
60ba797 to
289d6eb
Compare
recv_with_fds from vmm-sys-util was never safe, but was incorrectly not marked as safe. Handle it safely in every function where we have enough information to know that calling it will be safe, and propogate the unsafe to any function where we don't. Fortunately this is quite straightforward now all of the high-level methods have the guarantee that they're returning ByteValued types. Signed-off-by: Alyssa Ross <hi@alyssa.is>
alyssais
force-pushed
the
unsafe_iovec
branch
from
289d6eb to
ca06152
Compare
recv_with_fdsfrom vmm-sys-util was never safe, but was incorrectly not marked as safe. Handle it safely in every function where we have enough information to know that calling it will be safe, and propogate the unsafe to any function where we don't.Fortunately this is quite straightforward now all of the high-level methods have the guarantee that they're returning
ByteValuedtypes.Signed-off-by: Alyssa Ross hi@alyssa.is
This change is necessitated by rust-vmm/vmm-sys-util#135. If it's merged before the vmm-sys-util dependency is updated to a version with that change, it will produce compiler warnings, so I've marked it as a draft until that PR is merged.