fix: Remove 4096B chunk restriction of read/write_volatile_from/into #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where GuestMemory::read_volatile_from and GuestMemory::write_volatile_into would only copy data in chunks of at most 4096 bytes from/into the underlying stream. The check removed in this commit was errorneously copied from the read_from/write_into functions, which use a temporary buffer to transfer data (and this temporary buffer was capped to 4096 bytes). Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
JonathanWoollett-Light
approved these changes
Jan 8, 2024
Ablu
approved these changes
Jan 9, 2024
Ablu
approved these changes
Mar 4, 2024
andreeaflorescu
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where GuestMemory::read_volatile_from and GuestMemory::write_volatile_into would only copy data in chunks of at most 4096 bytes from/into the underlying stream. The check removed in this commit was errorneously copied from the read_from/write_into functions, which use a temporary buffer to transfer data (and this temporary buffer was capped to 4096 bytes).
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.