serial: fix corner case in enqueue_raw_bytes
#77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the serial fifo was full, but the user was trying to add 0 bytes to it with the `enqueue_raw_bytes` method, we were erroneously returning the FullFifo error. Refactored a bit `enqueue_raw_bytes` so that we return early in case the buffer to be enqueued is empty. Signed-off-by: Laura Loghin <lauralg@amazon.com>
gsserge
approved these changes
Jan 10, 2022
andreeaflorescu
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the serial fifo was full, but the user was trying to add 0 bytes to it , we were erroneously returning the FullFifo error. If the input buffer to be enqueued is empty, we return early now.