create vm-vcpu-ref crate #182
Conversation
andreeaflorescu
requested review from
alexandruag,
gsserge and
lauralt
as code owners
|
We still need to figure out how we're going to handle testing for this crate. It should be tested as part of vmm-reference, but I think it also makes sense to have its own pipeline so that we can get a feeling of how many lines we're covering here to make sure we keep the same quality bar as for other crates released from rust-vmm. |
andreeaflorescu
force-pushed
the
setup_vm_vcpu_ref
branch
from
d08af4c
to
fb4a21a
Compare
We can test it using the rust-vmm-ci. I added a separate commit for this configuration. Before we can run the test though we need to fix rust-vmm/rust-vmm-ci#95. |
andreeaflorescu
force-pushed
the
setup_vm_vcpu_ref
branch
from
1c361cf
to
9ecbaf7
Compare
This is going to be eventually published to crates.io. This is the crate that we're using for upstreaming building blocks for setting up the vm and vcpu for booting. For now it lives in vmm-reference, but we are considering moving it to its own worspace at some point in time. Signed-off-by: Andreea Florescu <fandree@amazon.com>
This is created as a symlink so we don't need to have another submodule to maintain. This was we only need to update rust-vmm-ci in one place. Also, having rust-vmm-ci in vm-vcpu-ref is needed so we can test this as a separate crate within the workspace. Not all features that we'll add to vm-vcpu-ref are going to necessarily be used by vmm-reference, so we could have specialized tests only for vm-vcpu-ref. Also, for publishing we would like to know what is the coverage of the crate. For the coverage test to be able to run only for vm-vcpu-ref, we also need to include this crate in the global workspace. Signed-off-by: Andreea Florescu <fandree@amazon.com>
b037be3 update test_coverage to allow running it on crates Signed-off-by: Andreea Florescu <fandree@amazon.com>
andreeaflorescu
force-pushed
the
setup_vm_vcpu_ref
branch
from
9ecbaf7
to
9f06f8c
Compare
This is going to be eventually published to crates.io. This is the crate
that we're using for upstreaming building blocks for setting up the vm
and vcpu for booting.
For now it lives in vmm-reference, but we are considering moving it to
its own worspace at some point in time.