Update SyscallReturnCode to support types other than i32. #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JBYoshi <12983479+JBYoshi@users.noreply.github.com>
JBYoshi
requested review from
liujing2,
sameo,
andreeaflorescu,
jiangliu,
roypat and
JonathanWoollett-Light
as code owners
9 tasks
roypat
approved these changes
Aug 24, 2023
| @@ -7,12 +7,12 @@ use std::os::raw::c_int; | |||
|
|
|||
| /// Wrapper to interpret syscall exit codes and provide a rustacean `io::Result`. | |||
| #[derive(Debug)] | |||
| pub struct SyscallReturnCode(pub c_int); | |||
| pub struct SyscallReturnCode<T: From<i8> + Eq = c_int>(pub T); | |||
JonathanWoollett-Light
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Currently,
SyscallReturnCodeis limited to system call return values of typei32. However, not all system calls return 32-bit integer values. For example, thereadsystem call returns anssize_ttype, which will map to a 64-bit integer on 64-bit systems.This PR updates
SyscallReturnCodeto be a generic type that can contain any signed integer value, so it can be used with other integer types. Since existing code may not specify generic type values, I set the type parameter to default to the existing type ofc_intto try and preserve compatibility.Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.