Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for GLX_EXT_framebuffer_sRGB #748

Closed
kvark opened this issue Mar 23, 2016 · 2 comments
Closed

Check for GLX_EXT_framebuffer_sRGB #748

kvark opened this issue Mar 23, 2016 · 2 comments

Comments

@kvark
Copy link
Contributor

kvark commented Mar 23, 2016

This GLX code fails on some machines:

        if reqs.srgb {
            if extensions.split(' ').find(|&i| i == "GLX_ARB_framebuffer_sRGB").is_some() {
                out.push(ffi::glx_extra::FRAMEBUFFER_SRGB_CAPABLE_ARB as c_int);
                out.push(1);
            } else {
                return Err(());
            }
        }

glxinfo seems to not feature the ARB version but it does have the EXT one:

server glx vendor string: NVIDIA Corporation
server glx version string: 1.4
server glx extensions:
    GLX_ARB_context_flush_control, GLX_ARB_create_context, 
    GLX_ARB_create_context_profile, GLX_ARB_create_context_robustness, 
    GLX_ARB_fbconfig_float, GLX_ARB_multisample, GLX_EXT_buffer_age, 
    GLX_EXT_create_context_es2_profile, GLX_EXT_create_context_es_profile, 
    GLX_EXT_framebuffer_sRGB, GLX_EXT_stereo_tree, GLX_EXT_swap_control, 
    GLX_EXT_swap_control_tear, GLX_EXT_texture_from_pixmap, 
    GLX_EXT_visual_info, GLX_EXT_visual_rating, GLX_NV_copy_image, 
    GLX_NV_delay_before_swap, GLX_NV_float_buffer, 
    GLX_NV_multisample_coverage, GLX_SGIX_fbconfig, GLX_SGIX_pbuffer, 
    GLX_SGI_swap_control, GLX_SGI_video_sync
client glx vendor string: NVIDIA Corporation
client glx version string: 1.4
client glx extensions:
    GLX_ARB_context_flush_control, GLX_ARB_create_context, 
    GLX_ARB_create_context_profile, GLX_ARB_create_context_robustness, 
    GLX_ARB_fbconfig_float, GLX_ARB_get_proc_address, GLX_ARB_multisample, 
    GLX_EXT_buffer_age, GLX_EXT_create_context_es2_profile, 
    GLX_EXT_create_context_es_profile, GLX_EXT_fbconfig_packed_float, 
    GLX_EXT_framebuffer_sRGB, GLX_EXT_import_context, GLX_EXT_stereo_tree, 
    GLX_EXT_swap_control, GLX_EXT_swap_control_tear, 
    GLX_EXT_texture_from_pixmap, GLX_EXT_visual_info, GLX_EXT_visual_rating, 
    GLX_NV_copy_buffer, GLX_NV_copy_image, GLX_NV_delay_before_swap, 
    GLX_NV_float_buffer, GLX_NV_multisample_coverage, GLX_NV_present_video, 
    GLX_NV_swap_group, GLX_NV_video_capture, GLX_NV_video_out, 
    GLX_SGIX_fbconfig, GLX_SGIX_pbuffer, GLX_SGI_swap_control, 
    GLX_SGI_video_sync
GLX version: 1.4
GLX extensions:
    GLX_ARB_context_flush_control, GLX_ARB_create_context, 
    GLX_ARB_create_context_profile, GLX_ARB_create_context_robustness, 
    GLX_ARB_fbconfig_float, GLX_ARB_get_proc_address, GLX_ARB_multisample, 
    GLX_EXT_buffer_age, GLX_EXT_create_context_es2_profile, 
    GLX_EXT_create_context_es_profile, GLX_EXT_framebuffer_sRGB, 
    GLX_EXT_stereo_tree, GLX_EXT_swap_control, GLX_EXT_swap_control_tear, 
    GLX_EXT_texture_from_pixmap, GLX_EXT_visual_info, GLX_EXT_visual_rating, 
    GLX_NV_copy_image, GLX_NV_delay_before_swap, GLX_NV_float_buffer, 
    GLX_NV_multisample_coverage, GLX_SGIX_fbconfig, GLX_SGIX_pbuffer, 
    GLX_SGI_swap_control, GLX_SGI_video_sync

Perhaps, we could check for EXT there as well?

pierrechevalier83 added a commit to pierrechevalier83/glutin that referenced this issue Apr 13, 2016
* by accepting GLX_EXT_framebuffer_sRGB as a sRGB capable framebuffer
* the new behaviour matches the wgl codel
tomaka added a commit that referenced this issue Apr 13, 2016
Fix pixel format support detection in glx. #748
pierrechevalier83 added a commit to pierrechevalier83/glutin that referenced this issue Apr 13, 2016
- to make the fix for rust-windowing#748 available to the repos downstream that need it
This was referenced Apr 13, 2016
pierrechevalier83 added a commit to pierrechevalier83/glutin_window that referenced this issue Apr 13, 2016
- to propagate fix for rust-windowing/glutin#748 downstream
pierrechevalier83 added a commit to pierrechevalier83/piston_window that referenced this issue Apr 13, 2016
pierrechevalier83 added a commit to pierrechevalier83/piston-examples that referenced this issue Apr 13, 2016
pierrechevalier83 added a commit to pierrechevalier83/piston that referenced this issue Apr 13, 2016
pierrechevalier83 added a commit to pierrechevalier83/glutin_window that referenced this issue Apr 13, 2016
pierrechevalier83 added a commit to PistonDevelopers/piston that referenced this issue Apr 13, 2016
@tyoc213
Copy link
Contributor

tyoc213 commented Nov 20, 2016

This is fixed on c68c0d9

@kvark
Copy link
Contributor Author

kvark commented Nov 20, 2016

Thanks!

@kvark kvark closed this as completed Nov 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants