Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix android job #1531

Merged
merged 1 commit into from
Nov 26, 2022
Merged

Conversation

kchibisov
Copy link
Member

No description provided.

@kchibisov kchibisov merged commit 2601911 into rust-windowing:master Nov 26, 2022
@MarijnS95
Copy link
Member

Fwiw I'm trying to back out of this change:

rust-mobile/cargo-subcommand#25
https://github.com/rust-windowing/android-ndk-rs/issues/371

The change to cargo doc was just cleanup; a docs build doesn't need access to the Android compiler nor linker.

@kchibisov
Copy link
Member Author

@MarijnS95 could you look into the recent android failure and update CI?

@MarijnS95
Copy link
Member

@kchibisov The problem is that -p glutin is passed twice. We don't deduplicate that and cargo-apk doesn't want to build two packages at once.

Is that something you can fix in yml?

@MarijnS95
Copy link
Member

Should be fixed in #1538.

@kchibisov
Copy link
Member Author

@MarijnS95 yeah, it just recently broke after the fix for the CI. So it's kind of strange if you haven't changed anything.

@MarijnS95
Copy link
Member

I did do a release recently, to fix some argument parsing breakage where were actually loosing the value of the first -p argument for complicated reasons...

Really, trying to reinvent cargo, its argument parsing and workspace detection is such a stupid and unreasonable hassle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants