Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 0.5.0 #96

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Conversation

kchibisov
Copy link
Member

--

Note, I can't push to crates.io, just opening a PR.

@kchibisov kchibisov requested a review from Lokathor July 14, 2022 16:43
@Lokathor
Copy link
Contributor

yeah this is good.

Usually i use the cargo-release tool which also makes a tag in the repo and stuff. i can probably do that later today.

@maroider
Copy link
Member

maroider commented Jul 14, 2022

Is it feasible for us to do the "semver trick" again? It would be nice to avoid ecosystem churn again.

@Lokathor
Copy link
Contributor

I don't remember how it works, but we're significantly altering the data type by moving around the fields, this is a thing where i don't think we should try to hide it. Old code is just plain broken by this change.

@kchibisov
Copy link
Member Author

Is it feasible for us to do the "semver trick" again? It would be nice to avoid ecosystem churn again.

I don't think there's a need to. The point is that we can likely make the crate stable with such api (though, I'd wait for rust to update its core, so we can remove cty dep and have zero dependencies).

Breaking it when we can break is better in my opinion. Since this migration will happen sooner or later, and in case of rust I'd suggest to make it sooner.

@Lokathor
Copy link
Contributor

ctypes got stabilized in core::ffi like this morning, so we're very close to that

rust-lang/rust#98315

@kchibisov
Copy link
Member Author

That's nice, so it won't take long. I'd wait for the rust version with those stable variants to reach major linux distributions and update to it releasing the v1.0.0 version.

@Lokathor
Copy link
Contributor

Well that will hit stable in about 12 weeks.

How far behind "latest stable" are most major Linux variants?

@kchibisov
Copy link
Member Author

How far behind "latest stable" are most major Linux variants?

Like 2 version or more (if we talk about Ubuntu and friend). So we'd have like half a year...

Though, we're not in a rush here, maybe the current design would need adjustments and recent changes would cause issues, so take it as a time before stabilization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants