Split wrapper around "display" and "window" into different types #37
Labels
Milestone
Comments
ids1024
added a commit
that referenced
this issue
Jan 6, 2023
WIP implementation of #37. Currently compiles on Linux, and splits parts of Wayland code to not need duplication for multiple windows.
ids1024
added a commit
that referenced
this issue
Jan 6, 2023
A `Context` is created with a display handle, and a `Surface` is created with a `&Context` and a window handle. Thus multiple windows can be created from the same context without duplicating anything that can be shared. This API is broadly similar to `wgpu` or `glutin`. On Wayland, the `Context` contains the `EventQueue`, which is shared between windows, and the `WlShm` global. On X11, `Context::new` checks for the availability of XShm, and contains a bool representing that as well as the `XCBConnection`. The shared context data is stored within the window in an `Arc`. On other platforms, the display isn't used and `Context` is empty. This does however test that the display handle has the right type on those platforms and fail otherwise. Previously the code didn't test that. Closes #37.
ids1024
added a commit
that referenced
this issue
Jan 6, 2023
A `Context` is created with a display handle, and a `Surface` is created with a `&Context` and a window handle. Thus multiple windows can be created from the same context without duplicating anything that can be shared. This API is broadly similar to `wgpu` or `glutin`. On Wayland, the `Context` contains the `EventQueue`, which is shared between windows, and the `WlShm` global. On X11, `Context::new` checks for the availability of XShm, and contains a bool representing that as well as the `XCBConnection`. The shared context data is stored within the window in an `Arc`. On other platforms, the display isn't used and `Context` is empty. This does however test that the display handle has the right type on those platforms and fail otherwise. Previously the code didn't test that. Closes #37.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@i509VCB suggested this on Matrix. I don't know about other platforms, but for Wayland it could definitely be desirable to not create a new registry, etc. for every window. Doesn't make a difference for uses with a single window, but with a lot of
wl_surfaces it definitely is a good idea to not duplicate everything like that.The text was updated successfully, but these errors were encountered: