-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can no longer create an Arc<FramebufferAbstract>> in vulkano (due to x11 IME changes) #472
Labels
Comments
|
Alright, give this a shot: https://github.com/francesca64/winit/tree/x11-imesender-sync I can't test PF Sandbox myself, since it fails at |
Merged
Yes that fixes the issue, thankyou! |
francesca64
added a commit
to francesca64/winit
that referenced
this issue
Apr 19, 2018
francesca64
added a commit
that referenced
this issue
Apr 21, 2018
* x11: Windows are Sync again Fixes #472 * Add test ensuring that Window is Sync Window must be Sync for Vulkano's Arc<FramebufferAbstract> to be usable.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@francesca64 Thanks for your continued work on winit. This appears to be introduced by: 09c809003 Any ideas on how to fix it?
This is preventing PF Sandbox from compiling on linux: https://travis-ci.org/rukai/PF_Sandbox
ImeSender is an alias for
std::sync::mpsc::Sender<(u64, i16, i16)>
which is not Sync.There is a field of type ImeSender on the
winit::os::unix::x11::Window
struct: https://github.com/tomaka/winit/blob/master/src/platform/linux/x11/mod.rs#L1007This means Window is not Sync and therefore
vulkano::image::SwapchainImage<Window>
is not sync.This prevents us from creating an
Arc<FramebufferAbstract>
which is the only way to store a frame buffer in a struct in vulkano.The following code no longer compiles with winit and vulkano sourced from github
We get this compilation error
The text was updated successfully, but these errors were encountered: