Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add web targets to travis #1220

Merged
merged 9 commits into from
Oct 13, 2019
Merged

Add web targets to travis #1220

merged 9 commits into from
Oct 13, 2019

Conversation

ryanisaacg
Copy link
Contributor

No description provided.

@Osspial
Copy link
Contributor

Osspial commented Oct 12, 2019

Could you add lines testing this on nightly?

@ryanisaacg
Copy link
Contributor Author

Any idea why appveyor is failing? This shouldn't be affecting it afaik

@Osspial
Copy link
Contributor

Osspial commented Oct 12, 2019

@ryanisaacg Looks like it's failing to configure gcc properly on nightly. It's probably a configuration error somewhere on Appveyor or rustup-init's side, though if it persists for a few days we should probably take a closer look at it.

@ryanisaacg
Copy link
Contributor Author

@Osspial Are we good to merge this even with appveyor failing?

@Osspial
Copy link
Contributor

Osspial commented Oct 13, 2019

@ryanisaacg yep

@Osspial Osspial merged commit a557b3c into rust-windowing:web Oct 13, 2019
@ryanisaacg ryanisaacg deleted the add-web-targets branch October 16, 2019 21:38
@cheako cheako mentioned this pull request Feb 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanisaacg @Osspial