-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In MacOS, only disable menu bar in exclusive fullscreen mode #1326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
window:willUseFullScreenPresentationOptions:
is not invoked if the user switches between borderless and exclusive fullscreen mode (because the window is already in "fullscreen" mode). I think what we need to do is to set presentationOptions
manually in set_fullscreen
when transitioning between the two. This can be tested with the "multithreaded" example.
Ok, I spent a bit more time with this. Here's where I'm at. In the transition from Borderless-->Exclusive, I used the In the transition from Exclusive-->Borderless, I read I'm still noticing a little bit of weirdness, but I'm not sure how to interpret it. Here's a screen recording to demonstrate.
I'm not sure why I have to go through the ceremony of switching desktops and selecting another window to get the menu bar to appear in the first place, but once it appears, it seems to be saved and restored correctly when transitioning between Borderless<-->Exclusive modes. Any thoughts? Also, should I be loading/retreiving |
7d01703
to
15884fe
Compare
@vbogaevsky could you review this? |
I've tested this on my Mac with the merge-conflict resolved and it worked like a charm. |
I assume one of you fixed the problem that the menubar was hidden when first entering borderless fullscreen, because I could not reproduce it. Please merge with the master first because there are a few issues that show up otherwise. After merging with master I do get one strange behaviour. Running
Let me know if you need help investigating this. |
If I go from alt+F back to borderless fullscreen then the menu is blacked out. This feels odd... |
I get the same reproduction as @ArturKovacs on MacOS 10.14.6 Mojave, with the latest |
I think I have a fix for this, see irh@99d3054 Are there any other issues remaining? I'd be happy to spend some more time on helping to push this forward. |
My attempt at a quick patch for #1195, which causes alacritty/alacritty#3023. It seems to fix the issue in Alacritty.
@aleksijuvani mentioned wanting
proposed_options
to be be replaced with user configured options via something likewindow.set_fullscreen_presentation_options
. I'm happy to take a crack at this, but I'm inexperienced with Rust and figured a quick patch might suffice for now.