platform_impl/linux/x11: fix deadlock in fn set_fullscreen_inner #1579
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a double-lock bug in windows.rs:
The first lock is at L641 in
set_fullscreen_inner()
:winit/src/platform_impl/linux/x11/window.rs
Lines 641 to 643 in 03335ce
Then
set_position_inner()
is called, where the second lock is at L988winit/src/platform_impl/linux/x11/window.rs
Lines 984 to 988 in 03335ce
The patch drops the MutexGuard before calling
set_position_inner()
inset_fullscreen_inner()
.