Impl. mouse capturing on web target #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvinhochun
force-pushed
the
web-mouse-capture
branch
from
08d2117 to
268642c
Compare
|
Hi @ryanisaacg can you please review this PR? |
alvinhochun
force-pushed
the
web-mouse-capture
branch
from
268642c to
5c5ce92
Compare
|
Sure, I'll review it this weekend. (Btw, in the future feel free to use the Github review request tool. I don't think Github notifies me when a PR goes from draft -> ready for review.) |
|
@ryanisaacg I don't think you can request reviews unless you're a member of rust-windowing. You can only re-request reviews iirc. |
ryanisaacg
approved these changes
Aug 29, 2020
|
That is an odd design choice on the part of Github. Feel free to ping me for reviews instead, I suppose! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo fmthas been run on this branchcargo docbuilds successfullyCHANGELOG.mdif knowledge of this change could be valuable to usersTasks:
web-sysusingPointerEventweb-sysusingMouseEvent(Frankly it would be much simpler ifwinitjust requires users to use aPointerEventpolyfill if they want to support browsers with onlyMouseEvent.)stdwebusingPointerEventstdwebusingMouseEvent(low priority, might be skipped sinceMouseEventsupport isn't even implemented in thestdwebbackend)Closes #1660
I have also refactored the pointer/mouse handling code a bit for the
web-systarget due to it getting quite messy, and it also helps when adding touch event handling later.The code had been changed for both
stdwebandweb-sys, but I have only tested withweb-sys. Though technically they both use the same web API so their behaviour should not be any different.