-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
android: ignore volume keys #1919
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fine for me
cc @MarijnS95 to check that you don't require it by chance
I miss proper justification why this is disabled. The main problem appears to be that What if someone built an audio application with Winit and listens for volume keys for some reason or another, and suddenly doesn't receive them anymore? Besides, we're at 65 characters of indentation now, this is getting beyond maintainable. |
It seems like there's a need to expose the ability to set the "handled" state of certain events, and not just on Android (see #1768). |
I definitely agree, but until that, as a stopgap, I'd love to see this merged! |
Fixed by #2748 |
cargo fmt
has been run on this branchcargo doc
builds successfullyCHANGELOG.md
if knowledge of this change could be valuable to users