-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new mappings for numlock, numpadenter and numpadcomma on X11 #1937
Conversation
I think this could merged as-is. It is kind of trivial, and the small bug it fixes does not need to wait that the new keyboard API is finished. |
Yeah we can merge this. @maroider do you have anything against this? |
ping? |
Welp, I completely forgot about this. I don't have anything in particular against this, but I suspect you'll have to take some extra steps to ensure the changelog entry ends up in the right place. |
@maroider good point. I suggest rebasing this on master. |
Was about to rebase, but made a mistake and now too many commits are visible in the pull request. Will fix later today. |
It looks like you did a merge instead of a rebase. |
Should be fixed now. Based on the master branch & force-pushed |
Co-authored-by: Markus Røyset <maroider@protonmail.com>
cargo fmt
has been run on this branchcargo doc
builds successfullyCHANGELOG.md
if knowledge of this change could be valuable to users